Skip to content

fix(EmptyPagePreview): several small issues#7474

Open
hjpalpha wants to merge 8 commits intomainfrom
fix-some-empty-page-issues
Open

fix(EmptyPagePreview): several small issues#7474
hjpalpha wants to merge 8 commits intomainfrom
fix-some-empty-page-issues

Conversation

@hjpalpha
Copy link
Copy Markdown
Collaborator

@hjpalpha hjpalpha commented May 7, 2026

Summary

  • error on missing Infobox/Team/Custom (e.g. on commons)
    • added early return
  • simplified logic for doNotIncludePlayerEarnings as only cs sets that
  • rl errors due to some ranking stuff expecting a mandatory args in rl infobox team custom
    • added an option to supress it from module code and applied that in the mpty page preview
  • nil catch for player/coach entries with missing pageName
  • fix some condition building (was bad in the old modules already and only worked by accident there ...)

How did you test this change?

dev

@hjpalpha hjpalpha requested review from a team as code owners May 7, 2026 09:49
Comment thread lua/wikis/rocketleague/Infobox/Team/Custom.lua
@hjpalpha hjpalpha changed the title fix(EmptyPagePreview): missing nil catch and RL speciality fix(EmptyPagePreview): several small issues May 9, 2026
@hjpalpha hjpalpha requested a review from ElectricalBoy May 9, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants